Fix segfault with expression bindings on database backends #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkofahl
added a commit
to faegi/mapserver
that referenced
this pull request
Sep 30, 2015
… iteminfo is freed. (MapServer#5161)
… iteminfo is freed. (MapServer#5161)
mkofahl
force-pushed
the
changedExpressionObj
branch
from
485f26d
to
045beb0
Compare
|
@tbonfort Looks good to me now. |
|
@sdlime can you please check this is OK for 7.0.1 ? |
|
Thomas: Missed this one. Ok to include IMHO... --Steve |
|
Applied to branch-7-0 in 7413952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations, attribute bindings may cause a segmentation fault, when executing multiple MapScript operations, e.g.
queryByPoint()followed bydraw()on the same layer. This is because the expression is tokenized only once - when uninitialized. In case of an attribute binding, the token bindval index points to the sql column-index built from the list of required attributes, in case ofqueryByPoint()all attributes are requested. A possibly followingdraw()will reduce the number of attributes to be queried from the database, so the column index in the resultset changes, but the expression token is still the same.The fix is to free the expression object, when
msLayerFreeItemInfo()is called, which is currently done atLayerClose()only.